fix(dashboards): Ensure custom tag options are displayed when adding global filters #102597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e types aren't removed
Ahmed-Labs
changed the title
github-actions
bot
added
the
Scope: Frontend
Ahmed-Labs
changed the title
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Ahmed-Labs
changed the title
nikkikapadia
approved these changes
Nov 3, 2025
Ahmed-Labs
deleted the
ahmedmo/fix/dashboard-global-filter-custom-tags
branch
shashjar
pushed a commit
that referenced
this pull request
Nov 4, 2025
…global filters (#102597) Custom tags were being filtered out from the tag options when adding global filters. This PR handles the case where these custom tags don't have value types. Fixes [DAIN-1057](https://linear.app/getsentry/issue/DAIN-1057/fix-bug-where-custom-tags-arent-shown-when-adding-global-filters)
priscilawebdev
pushed a commit
that referenced
this pull request
Nov 6, 2025
…global filters (#102597) Custom tags were being filtered out from the tag options when adding global filters. This PR handles the case where these custom tags don't have value types. Fixes [DAIN-1057](https://linear.app/getsentry/issue/DAIN-1057/fix-bug-where-custom-tags-arent-shown-when-adding-global-filters)
andrewshie-sentry
pushed a commit
that referenced
this pull request
Nov 13, 2025
…global filters (#102597) Custom tags were being filtered out from the tag options when adding global filters. This PR handles the case where these custom tags don't have value types. Fixes [DAIN-1057](https://linear.app/getsentry/issue/DAIN-1057/fix-bug-where-custom-tags-arent-shown-when-adding-global-filters)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom tags were being filtered out from the tag options when adding global filters. This PR handles the case where these custom tags don't have value types.
Fixes DAIN-1057